Skip to content

fix(config): default omitted model tools capability - #50702

Open
LeoParkerOu wants to merge 1 commit into
anomalyco:devfrom
LeoParkerOu:codex/fix-50340-tools-default
Open

LeoParkerOu wants to merge 1 commit into
anomalyco:devfrom
LeoParkerOu:codex/fix-50340-tools-default

Conversation

@LeoParkerOu

Copy link
Copy Markdown

Issue for this PR

Closes #50340

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

A configured model may specify input and output capabilities without a tools field. The user-facing config schema previously rejected that provider entry, so it was silently skipped.

This change makes tools optional in the config schema and normalizes an omitted value to false when the provider is loaded. Explicit true and false values remain unchanged. A regression test verifies provider loading and capability preservation.

How did you verify your code works?

  • Provider tests pass.
  • Full config test suite passes.
  • Core typecheck passes.
  • Prettier check passes on changed files.

Screenshots / recordings

Not applicable.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

I found a potential duplicate PR:

Related PR:

The current PR #50702 and #49940 both deal with making tools optional and normalizing omitted values in provider/capability configuration. You should verify whether #49940 was merged, closed, or abandoned, and confirm that #50702 isn't duplicating that work.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

config: model capabilities requires tools — missing field silently skips whole provider (undocumented)

1 participant