Skip to content

test(core): strengthen config diagnostic localization evidence (origin #50832) - #68

Open
kvnloo wants to merge 3688 commits into
devfrom
factory/config-diag-localize-strengthen-50832
Open

kvnloo wants to merge 3688 commits into
devfrom
factory/config-diag-localize-strengthen-50832

Conversation

@kvnloo

@kvnloo kvnloo commented Sep 26, 2026

Copy link
Copy Markdown
Owner

Summary

Fork-only strengthen of origin anomalyco#50832 / 20260925-opencode-50832-strengthen-001.

Pin lineage note: tip dev lacks packages/core/src/config/normalize.ts (architecture drift). Branch based on origin PR head.

Evidence

Test

cd packages/core && bun test test/config/normalization.test.ts
# 30 pass / 0 fail

github_writes_origin=0

opencode and others added 30 commits September 16, 2026 04:41
A stalled catalog refresh kept reconnection from completing and prevented
new prompts. Allow the stream to reconnect independently of catalog state.
Remove the attention.enabled master switch. Notifications and sounds are
now enabled independently and both default to off. Existing enabled keys
are ignored; there is no migration.
Co-authored-by: adamdotdevin <2363879+adamdotdevin@users.noreply.github.com>
Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>
Apply the selected model on blank Enter and simplify shared prompt submission setup and recovery.\n\nfrom OpenCode
Add a global location reload endpoint, shared shutdown lifecycle, client resynchronization, and the TUI /reload command.\n\nfrom OpenCode
Co-authored-by: LukeParkerDev <10430890+Hona@users.noreply.github.com>
rekram1-node and others added 25 commits September 21, 2026 18:09
Co-authored-by: Brendonovich <14191578+Brendonovich@users.noreply.github.com>
Co-authored-by: jlongster <17031+jlongster@users.noreply.github.com>
Co-authored-by: Brendonovich <Brendonovich@users.noreply.github.com>
Co-authored-by: Brendonovich <Brendonovich@users.noreply.github.com>
…ield

Config normalization discarded the parse issue that explained why a value
was rejected, so an invalid `capabilities` object reported only the enclosing
provider path.

Decode through `SchemaParser.decodeUnknownResult` instead of the `Option`
adapters and carry the issue into the diagnostic, appending the failing field
path so the log names the offending field. Value redaction is unchanged: the
diagnostic message stays generic and only schema positions are added.

Closes anomalyco#50340
…ng leaf

Strengthen origin anomalyco#50832: load-boundary coverage for one invalid nested
model leaf + valid sibling provider, plus a negative whole-object
diagnostic control.
@github-actions

Copy link
Copy Markdown

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions

Copy link
Copy Markdown

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.