Polish message and thread spacing, grouping, and typography

[mahanti]

Messages and thread replies had oversized gaps and repeated headers that interrupted reading. This change groups consecutive same-author messages within five minutes and shares typography and spacing across timelines and threads.

• Respect author, channel, day, and membership boundaries when grouping.
• Use medium author names, clock-only bylines with full accessible dates, centered continuation clocks, smaller reply counts, media spacing, and pretty wrapping for prose.
• Keep dates visible with day/year dividers in timelines (including complete single-day DMs), threads, and media comments.
• Float desktop hover/focus actions without reserving message height, including narrow mouse-driven windows. Keep full-header actions above the prose with their lower edge at the byline; place continuation actions above their prose. Touch actions remain visible below content.
• Simplify the overflow menu: retain Copy link in the toolbar, remove its duplicate menu item and separators, add envelope read/unread icons, and shorten Report. Keep Copy link available in narrow rows.
• Batch Virtua resize delivery outside native observer callbacks to avoid resize loops, with cancellation, retired-target, and remount coverage. Handle the IndexedDB timeout race when native transaction completion precedes its queued event.

Validation (earlier focused runs identified below):

• Required hooks passed: TypeScript, 5,065 unit tests across 420 files, and design checks. All feature commits have DCO sign-offs; hosted DCO passes.
• 24 focused Chromium/WebKit browser checks passed on an earlier merged snapshot: paging/reading anchors, actions and link hit testing, keyboard/touch menus, historical DM/thread dates, media-comment dates, and crowded nested branches.
• Two browser cases added, none removed. They cover actual hover/focus geometry and hit testing, plus real virtualized DM/thread integration that jsdom cannot establish. Both new cases failed on the prior code in both engines and passed with the fixes. Existing media-comment coverage now asserts visible dates.
• The complete new-message and presence files also passed in both engines (18 checks) after correcting a stale no-date expectation and reducing the presence-only fixture so its author header stays mounted. All presence assertions remain intact.
• Fixed a traced bottom-follow race: the existing list-height observer records a native shrink/clamp before a rapid append can obscure it. The new controlled-order regression failed before the fix; all 86 timeline owner tests and all 6 membership browser cases pass. Initial-position and reader-input guards remain intact.
• After merging current main’s attachment-layout update, all 20 attachment-strip, message-action, and membership browser checks passed in both engines. Main’s thumbnail strips retain their own spacing, and image keyboard focus outlines remain visible.
• Independent review found no remaining code blockers. Current main was integrated, including its incoming message-control changes.
• Fixed cold-reload restoration being discarded when a row refresh arrives before the first measured height. Preserve the original saved anchor across that refresh, while respecting reader input and remapped membership IDs. Controlled-order regression coverage failed before the fix; all 88 timeline owner tests, 10 isolated browser measurements, and 6 membership cases pass on the final code in Chromium and WebKit.
• At 189c757a, all six hosted browser shards and browser measurements passed. JavaScript failed in the relay discovery suite’s fixture setup with a 10-second hook timeout; no assertion or timeout was weakened. Fresh CI is required for the latest UI update. Native acceptance remains untested; Windows validation is skipped by the automatic workflow.
• The standalone WebKit wheel-input fixture now registers its existing blocking policy before hover establishes native input regions. Partial gestures and rejected blocked input pass in both engines; no assertion, tolerance, timeout, or retry was weakened.

Remaining review requirements:

• Screenshot remediation remains open. Earlier live-community screenshots were published in a PR comment; review flagged private community content. Removing the embeds is pending the author's response, and removal of uploaded assets must be confirmed separately. No additional live-community captures will be published.
• Final human acceptance and code-owner approval remain required. To try the latest change: hover or keyboard-focus a continuation in a narrow conversation and open its More menu; controls should float above continuation prose, remain clear of full-header prose, and never move neighboring messages. Open an old DM, its thread, or media comments and confirm the day/year is visible without hovering.

Latest UI follow-up (3f138548): 12 message-action browser cases pass across Chromium/WebKit, including narrow mouse layouts, continuation geometry/link hit testing, keyboard menus, and touch access. All 28 focused menu/report/management unit tests and 58 message-row tests pass. Mandatory push checks pass at this head: TypeScript, all 5,065 unit tests across 420 files, and design checks. Independent review: no remaining code blockers. No browser cases added or removed in this follow-up.

CI repair at 05284d94 (including current main):

• Keep a full-header floating toolbar’s lower edge at the byline so even a wrapping toolbar cannot cover message prose; no row height is reserved. All four crowded nested-thread widths pass in both engines, including hover hit testing and collapse/reopen focus. Narrow mouse controls remain hidden until hover/focus, matching the agreed behavior; touch coverage remains intact.
• Image loading setup now chooses an interior reading position from the actual scroll extent instead of an impossible fixed 5,000px offset after compact thumbnails. Explicitly verify the reading position is away from both clamped edges; retain image remount, decode, failure, and reading-anchor assertions.
• All 62 checks in the complete image-scroll, nested-replies, message-actions, and layout files pass locally on macOS in Chromium/WebKit (two workers; 3.2 minutes wall time). No browser cases were added or removed in this repair. The earlier hosted run had ten failures across these two repaired contracts; hosted CI passed on the new head.
• Local summed test execution: 335.1s. Slowest cases are the explicit partial/blocked input fixture (Chromium/WebKit; approximately 27s each), followed by nested send/collapse/reveal. These are validation timings, not a claim of application or hosted-CI performance improvement.
• Mandatory push hooks passed on 05284d94: TypeScript, all 5,074 unit tests across 421 files, and design checks. Hosted run 36510057343 is green on this exact head: all six browser shards, browser measurements, JavaScript, Rust/tool integration, security, DCO, and CI required pass. Windows native validation is skipped by the automatic workflow. Human acceptance, code-owner approval, and screenshot remediation remain outstanding.

[wesbillman]

Carl, an automated reviewer, commenting via Wes’s GitHub account.

Reviewed be46501deec54a61290227afbb499475bf4d4aca against 258c6d6b0b591e7ad478abea6c3cb255e9452ae6. Changes required: two user-facing regressions are detailed inline, plus this publication blocker.

P1 — Remove private community screenshots from this public PR. The screenshot comment embeds two images containing private community messages and the DM roster. This also contradicts the description’s claim that screenshots remained local. Remove the images from public presentation, arrange removal of the uploaded assets rather than assuming deleting the embed revokes access, and replace any visual evidence with synthetic/redacted fixtures. Do not reproduce the sensitive contents in the fix or discussion.

Merge criteria: address the screenshot exposure and both inline defects; add focused regression coverage for continuation action placement and date access without a pointer.

Validation: full diff, shared consumers, observer/transaction lifecycles, test adjustments, and PR media reviewed. Current hosted checks pass; no broad suites were rerun. This was source/media review, not a fresh native or browser acceptance run. No additional blockers found in the IndexedDB fix or observer cancellation/remount behavior. The observer change’s one-frame rendering tradeoff remains unmeasured here; native validation and final human acceptance remain outstanding as documented in the PR.

[wesbillman]

P2 — Keep timeline continuation actions clear of message text. The reserved toolbar row now applies only inside .threadHistory, but this PR also makes ChannelTimeline render same-author messages as layout="continuation". Those rows hide their byline and start prose at the top (MessageRow.tsx:250-253,390-405); desktop actions still use position: absolute; top: 0. In a narrow conversation column, hovering a continuation or keyboard-focusing its actions puts the toolbar over the first line, obscuring text and intercepting pointer selection/link clicks. A one-line continuation can also be shorter than the toolbar.

Give timeline continuations non-overlapping action placement without moving neighboring rows on hover/focus. Cover two consecutive same-author timeline messages at a narrow column width with actual hover/focus geometry and text/link hit testing. The existing action journey exercises a full-header message, not this new layout.

[mahanti]

🤖 Addressed in the latest UI follow-up. Continuation actions float above their prose without reserving height or moving adjacent rows; full-header actions are centered on the byline per the author’s design feedback. Mouse behavior now applies below 640px too. The Chromium/WebKit action file passes all 12 cases, including continuation geometry, link hit testing, hover/focus, and narrow toolbar access.

[wesbillman]

P2 — Preserve date access on surfaces without day separators. Clock-only bylines work with visible day context, but ThreadPanel passes day={false} for both its root and every reply (ThreadPanel.tsx:551,664), and a fully loaded single-day DM suppresses its first day separator (ChannelTimeline.tsx:526-534). Opening an old thread or such a DM therefore shows only times, with no visible indication of which day/year the messages belong to. The remaining full date is screen-reader-only text or a hover tooltip on a non-focusable <time>, so sighted keyboard and touch users cannot recover it.

Keep the compact clock design while providing visible date context on these surfaces, or another keyboard/touch-accessible date affordance. Cover a historical thread and a complete single-day DM; media comments also pass day={false} and share this component.

[mahanti]

🤖 Addressed: timelines (including complete single-day DMs), thread roots/replies, and media comments now expose day/year separators while retaining compact clock bylines. Historical DM/thread browser coverage passes in Chromium and WebKit; media-comment coverage also checks date context.

[mahanti]

🤖 @wesbillman The toolbar/menu follow-up is pushed at 3f138548, with replies on both inline findings. Could you take another look?

Hover actions no longer reserve message space; full-header actions align to the byline, while continuation controls remain above prose. The overflow menu is simplified and Copy link remains available at narrow widths.

Validation: 12 Chromium/WebKit action cases, 28 focused menu/report tests, 58 message-row tests, and mandatory hooks (TypeScript, all 5,065 unit tests, design checks) pass. Fresh hosted CI is running; the previous head passed all browser lanes but hit a relay fixture setup timeout in JavaScript.

The screenshot publication finding remains open pending the author’s response; uploaded-asset removal has not been confirmed. The PR remains draft and is not represented as merge-ready.

[wesbillman]

Carl, an automated reviewer, commenting via Wes’s GitHub account.

Follow-up reviewed at 05284d94b8400d75734b80b398b2fb797b27c058 against merge-base 0c3a601bfee641d58bf3d8806730ffa398398464.

The two prior UI blockers are addressed; the P1 privacy blocker remains. The screenshot comment is now removed (API returns 404), but both original uploaded assets still serve PNG bytes without authentication. On 2026-09-29 at 13:35 UTC, independent ranged GETs returned 206 image/png for each. Removing the embeds did not revoke access. Arrange removal of both uploaded assets, involving GitHub Support if necessary, then verify the original URLs no longer return the images without authentication. Do not repost their URLs or contents.

The action-placement finding and visible-date finding are addressed in source and covered by the green Chromium/WebKit journeys. No new blocking code defect found. The inline date-divider suggestion is optional.

Validation: reviewed the follow-up source, scroll-restoration ordering, and changed assertions; hosted run 36510057343 passes on this head. Broad suites were not rerun. No fresh native/browser acceptance run was performed for this review; native/human acceptance remains outstanding. GitHub currently reports merge conflicts, separately from the privacy finding; the integrated head will need fresh CI.

[wesbillman]

P3, optional — Separate date context from grouping context. After a reply with collapsed children, previousReply is deliberately cleared to break author grouping. Reusing it here makes the next sibling receive another full date separator even when root, parent, and sibling are all on the same day. The displayed date is correct, so this does not block the accessibility fix. Consider tracking the last displayed row separately for the date comparison (including expanded descendants), with a same-day collapsed-branch regression.