Align reply summaries with message content - #408
Conversation
Signed-off-by: Arjun Mahanti <arjun@squareup.com>
|
wesbillman
left a comment
There was a problem hiding this comment.
Star Lord — automated source review via Wes’s account
No actionable findings. The two-line CSS change is appropriately scoped to reply-summary buttons.
Messages.module.css:99–104,551–562: the message body is a column flex container.align-self: flex-startprevents the summary from stretching across it; the negative inline-start margin offsets the existing--space-1padding without removing the padded interaction surface. The shared Button styling remains untouched.MessageRow.tsx:591–617retains the accessible reply-count/unread label, native button activation and explicit trigger focus. Inspected the timeline caller, shared summary content and thread close/error/Retry paths: this selector changes layout only, not focus ownership, restoration or recovery controls. Actual rendered focus behavior remains unverified.
Pins: head 7074e59e2cbae8a2cabadf10fcfdafd75fb5f943; base 745da5d3f037b6f509543d5b3bd2f1cae527d8a9. Reviewed an immutable archive verified against 1,695 regular Git blobs, with no dirty checkout inputs.
Validation limits: Source-only; no PR code, tests, installs, builds or app/browser workflows executed. The PR reports Chromium/WebKit measurements at 390px and 1440px, an old-style regression check and human acceptance; those are author-reported, not independently reproduced here. Browser cases added/removed: zero. One hosted snapshot showed JavaScript and nine browser shards still running; three browser shards, browser measurements, Rust/tool integration, security checks and DCO passed; Windows was skipped. Native layout, zoom/narrow-layout behavior and runtime accessibility are not certified by this review.
Public material: The repository is public. Inspected the complete two-line source diff, description and sole commit message; no concrete internal coordination URL, deployment/workspace identifier or secret found there. No images/media are attached to the description; the locally mentioned screenshots were not supplied and were not inspected. Legitimate commit authorship/sign-off metadata is retained.
Non-blocking COMMENT only — not approval or merge authorization.
…t-update-drafts * commit '0a4982797f38164d75e3e8f48e58fabb9dd59e66': (66 commits) Show saved local and relay inventory while retaining existing import controls (#286) feat(channels): edit channel details with confirmed saves (#369) test(channels): discover the hoverable width for activity corners (#416) Fix flaky WebKit menu focus browser test (#409) Test Goose connections and fix Pi test false failures (#383) feat: open threads with verified newest-first windows (#154) Add agent conversation context selection (#382) test: keep behavioral coverage without cosmetic matrices (#410) Fix reading position and composer caret on channel return (#411) fix(channels): prevent clipped activity rows and remove separators (#377) ci: publish signed macOS updater artifacts in prereleases (#387) feat(messages): add jump to latest controls (#374) Align reply summaries with message content (#408) Add centered thinking pills to agent avatars (#351) Keep focus where the user moved it when a menu finishes closing (#355) Browse legacy identities without a destination and review text before cloning (#285) Show separate identity cards and prevent duplicate imports (#225) Polish message and thread spacing, grouping, and typography (#364) Remove the Away avatar badge stroke (#395) fix(profiles): hide activity on human profiles (#391) ... Signed-off-by: Sol <49aa1f65411fd096d2e2ec144f1e7aa36fdc76d1b907cfdf7be000c66f9d3b8e@buzz.block.builderlab.xyz>
* origin/main: (25 commits) Show saved local and relay inventory while retaining existing import controls (#286) feat(channels): edit channel details with confirmed saves (#369) test(channels): discover the hoverable width for activity corners (#416) Fix flaky WebKit menu focus browser test (#409) Test Goose connections and fix Pi test false failures (#383) feat: open threads with verified newest-first windows (#154) Add agent conversation context selection (#382) test: keep behavioral coverage without cosmetic matrices (#410) Fix reading position and composer caret on channel return (#411) fix(channels): prevent clipped activity rows and remove separators (#377) ci: publish signed macOS updater artifacts in prereleases (#387) feat(messages): add jump to latest controls (#374) Align reply summaries with message content (#408) Add centered thinking pills to agent avatars (#351) Keep focus where the user moved it when a menu finishes closing (#355) Browse legacy identities without a destination and review text before cloning (#285) Show separate identity cards and prevent duplicate imports (#225) Polish message and thread spacing, grouping, and typography (#364) Remove the Away avatar badge stroke (#395) fix(profiles): hide activity on human profiles (#391) ... Signed-off-by: Sol <49aa1f65411fd096d2e2ec144f1e7aa36fdc76d1b907cfdf7be000c66f9d3b8e@buzz.block.builderlab.xyz> # Conflicts: # src/bundled/agents/AgentsPage.test.tsx # src/bundled/agents/AgentsPage.tsx
Reply summaries were stretching across the message column, centering their avatars and reply counts. Keep the summary button at its content width and offset its existing padding so its contents line up with the message text.
Validation:
buzz-review-completed