fix(profiles): hide activity on human profiles - #391
Merged
Merged
Conversation
People's profiles no longer render the Info tab's "Latest activity" card, which carried the "Recent activity" list and the "View activity" launcher. The card now mounts only when the profile is already a known agent: a self-declared agent profile hint or a local library record, the same display-only evidence that picks the squircle avatar and the Archive section. Ownership and telemetry access are unchanged. The browser fixture serves a test-created kind 0 on later profile reads and models the identity archive consent batch (profile plus relay roster) that a known-agent profile now issues through the production broker. The profile activity journey opens a person's profile first and asserts that neither the preview nor the launcher appears once metadata has settled, then continues with a declared agent. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Matt Toohey <contact@matttoohey.com>
Extend the profile component test with an identity recognized through session.agentChoices without is_agent metadata. Assert that its activity preview and View activity button remain available. Signed-off-by: Matt Toohey <contact@matttoohey.com>
matt2e
marked this pull request as ready for review
September 29, 2026 03:27
wesbillman
reviewed
Sep 29, 2026
wesbillman
left a comment
Collaborator
There was a problem hiding this comment.
Star Lord — automated source review via Wes’s account
No actionable findings in this diff.
Reviewed head e72bc49320673e998495e89b48d706eb72788574 against base df4b735c8bfa98018ee4e65de60b5fb8fd0e6f31.
ProfilePanel.tsx:417–423reuses the existing exact-key known-agent projection (public agent hint or loaded session choices). It removes the activity card/launcher for people without changing ownership or telemetry admission.ProfileActivitystill requires originating-channel context and an available panel contribution; mounting it only subscribes to existing capture.- Traced classification updates, session/target replacement, plugin disable/access-reset fences, contextual activity navigation, and adjacent success/close and error/retry focus paths. The component regression covers people, declared agents and library-only agents; the existing browser journey retains exact identity/channel routing and uses settled metadata before its new absence assertions. The archive-consent fixture batch matches the production reader and does not grant its viewer an admin role.
- Public-material check: inspected the description, both attached before/after images, all seven changed files and both PR commits. No actionable privacy finding in those surfaces; both commits contain DCO sign-offs.
Validation limits: source inspection only, using an isolated snapshot with all 1,682 blobs checked against the pinned tree; no dirty source inputs, code execution, installs, tests or app launches. A one-time hosted-check snapshot reports CI required and DCO Check successful at this head (Windows native validation skipped). That is not independent runtime/focus validation or human acceptance. The description’s broader validation/human-testing checklist and unreported before/after fixture timings remain gaps, not established by this review. This is a COMMENT review, not approval or merge authorization.
wesbillman
approved these changes
Sep 29, 2026
johnmatthewtennant
pushed a commit
that referenced
this pull request
Sep 29, 2026
…t-update-drafts * commit '0a4982797f38164d75e3e8f48e58fabb9dd59e66': (66 commits) Show saved local and relay inventory while retaining existing import controls (#286) feat(channels): edit channel details with confirmed saves (#369) test(channels): discover the hoverable width for activity corners (#416) Fix flaky WebKit menu focus browser test (#409) Test Goose connections and fix Pi test false failures (#383) feat: open threads with verified newest-first windows (#154) Add agent conversation context selection (#382) test: keep behavioral coverage without cosmetic matrices (#410) Fix reading position and composer caret on channel return (#411) fix(channels): prevent clipped activity rows and remove separators (#377) ci: publish signed macOS updater artifacts in prereleases (#387) feat(messages): add jump to latest controls (#374) Align reply summaries with message content (#408) Add centered thinking pills to agent avatars (#351) Keep focus where the user moved it when a menu finishes closing (#355) Browse legacy identities without a destination and review text before cloning (#285) Show separate identity cards and prevent duplicate imports (#225) Polish message and thread spacing, grouping, and typography (#364) Remove the Away avatar badge stroke (#395) fix(profiles): hide activity on human profiles (#391) ... Signed-off-by: Sol <49aa1f65411fd096d2e2ec144f1e7aa36fdc76d1b907cfdf7be000c66f9d3b8e@buzz.block.builderlab.xyz>
johnmatthewtennant
pushed a commit
that referenced
this pull request
Sep 29, 2026
* origin/main: (25 commits) Show saved local and relay inventory while retaining existing import controls (#286) feat(channels): edit channel details with confirmed saves (#369) test(channels): discover the hoverable width for activity corners (#416) Fix flaky WebKit menu focus browser test (#409) Test Goose connections and fix Pi test false failures (#383) feat: open threads with verified newest-first windows (#154) Add agent conversation context selection (#382) test: keep behavioral coverage without cosmetic matrices (#410) Fix reading position and composer caret on channel return (#411) fix(channels): prevent clipped activity rows and remove separators (#377) ci: publish signed macOS updater artifacts in prereleases (#387) feat(messages): add jump to latest controls (#374) Align reply summaries with message content (#408) Add centered thinking pills to agent avatars (#351) Keep focus where the user moved it when a menu finishes closing (#355) Browse legacy identities without a destination and review text before cloning (#285) Show separate identity cards and prevent duplicate imports (#225) Polish message and thread spacing, grouping, and typography (#364) Remove the Away avatar badge stroke (#395) fix(profiles): hide activity on human profiles (#391) ... Signed-off-by: Sol <49aa1f65411fd096d2e2ec144f1e7aa36fdc76d1b907cfdf7be000c66f9d3b8e@buzz.block.builderlab.xyz> # Conflicts: # src/bundled/agents/AgentsPage.test.tsx # src/bundled/agents/AgentsPage.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hide the activity preview and View activity action on human profiles, using the existing known-agent check. Ownership and telemetry permissions remain unchanged.
Add component regression coverage, extend the existing profile activity browser journey, and update profile documentation and fixtures. No browser cases were added or removed; the existing journey checks profile metadata and activity routing through the app and relay.
Validation: branch diff check passed; commit includes DCO sign-off. Runtime tests, fail-then-pass evidence, agent review, and human app testing remain unverified in this PR-creation pass. Kept in draft pending the contribution checklist.
Before and after
Same synthetic human profile (Alex Morgan, no agent hint or library record), Info tab, Chromium, light theme, 1280 × 900 viewport. Both captures use identical fixture data and retained activity, with profile metadata settled.
Before —
0c3a601b(parent ofe1c546a4): the human profile shows Latest activity, its Recent activity list, and the View activity launcher.After —
e72bc493(branch head, including the library-only agent coverage): the same human profile shows neither the activity card nor its launcher.Focused browser capture assertions passed at both revisions, and both screenshots were visually inspected. The broader validation and human-testing checklist above remains outstanding.