Make GOOSE values readable and keep the workspace lightweight - #41
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61bcf334ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (snapshot.IsChanged) | ||
| { | ||
| _highlightUntilUtc = DateTimeOffset.UtcNow.AddSeconds(5); | ||
| IsHighlighted = true; |
There was a problem hiding this comment.
Preserve value highlights across retransmission coalescing
When a GOOSE state change is followed by a fast retransmission before the 100 ms UI flush, _pendingGooseFrames keeps only the last snapshot for that stream; that retransmission normally has IsChanged == false, so this branch never starts the new 5-second highlight even though the current value changed. This makes the inspector miss highlights for normal GOOSE change/retransmit traffic; preserve the recent-change flag separately or drive the highlight from the non-coalesced timeline snapshots.
Useful? React with 👍 / 👎.
Field-accepted COMTRADE workstation integration from the P1D stack through P1D.7. Includes synchronized Time Signals, Phasor, Harmonics, native six-loop Locus, RMS/PRI-SEC presentation, cursor measurements, first-click fault-record reliability, deterministic analog-before-digital ordering, Clear/Auto state authority, retained/screen-space waveform rendering, synchronous cursor transforms, bounded latest-wins analysis/readout scheduling, and bridge-only packaging. Exact merge-prep head passed Build ARSAS #2571, SV #1576, COMTRADE integration #171, and Windows Installer #893 against current main. The production AGENTS.md from main is preserved. ArdIrec PR #41 was merged first and the ARSAS lock remains pinned to the exact field-tested bridge commit. FAT workstation files/branches are intentionally untouched and remain under their independent field gate.
Root-cause audit
bits(xx, unused=n)renderer, which is accurate protocol evidence but not beginner-readable.Corrections
true/falseOpen [01],Closed [10],Intermediate [00], orInvalid [11]NetworkInterfaceidentity by MAC/GUID and suppress accidentalArIED61850labelsSafety
The GOOSE subscriber remains receive-only. Npcap capture, ARIEC61850 parsing, sequence/TAL supervision, SCL/live-discovery binding, and command/control behavior are unchanged.