fix: defer handler response until stream shell payload - #2231
Merged
Conversation
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
katywings
force-pushed
the
fix-2229-await-stream-shell-payload
branch
2 times, most recently
from
July 24, 2026 12:53
299dcf2 to
c40ffb1
Compare
🦋 Changeset detectedLatest commit: ab1f90d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lxsmnsyc
reviewed
Jul 24, 2026
katywings
force-pushed
the
fix-2229-await-stream-shell-payload
branch
4 times, most recently
from
July 25, 2026 13:35
0065376 to
34e3269
Compare
katywings
force-pushed
the
fix-2229-await-stream-shell-payload
branch
from
July 25, 2026 13:38
0c72594 to
1863622
Compare
katywings
force-pushed
the
fix-2229-await-stream-shell-payload
branch
from
July 25, 2026 14:01
1863622 to
2b3bf6d
Compare
katywings
marked this pull request as ready for review
July 25, 2026 15:28
birkskyum
approved these changes
Jul 25, 2026
brenelz
approved these changes
Jul 25, 2026
This was referenced Jul 26, 2026
Closed
brenelz
added a commit
that referenced
this pull request
Jul 29, 2026
Brings the v2 rc line (through 2.0.0-rc.6) into the Solid 2 branch. Ported main features onto the Solid 2 architecture: - Server-function error handler (#2262): wired through handleServerFunctionRequest's transformResult hook and the solid-start:server-fn-error-handler virtual module. - Custom seroval plugins (#2250): serialization.plugins now feeds the @solidjs/web codec on both the client transport and the server handler. - ~ alias fix for workspace packages (#2239): adopted appRootAlias in place of the global resolve.alias entry. - Dev toolbar (#2049, replaces the dev overlay): ported to Solid 2 (Errored/Loading, onSettled, two-arg createEffect, draft-mutation stores, terracotta 2 subpath imports, @solidjs/web Portal/Dynamic/JSX, createMemo(async) instead of createResource). Protocol-specific pieces (SerovalChunkReader, body-format markers) moved local to the toolbar. - Deferred stream response via h3 iterable() (#2231), StartHandler type (#2234), routerLoad restore (#2228), nonce on streaming redirect script (#2252), ResizeObserver-loop filter (#2240) all kept. Kept deleted (superseded by vite-plugin-solid / @solidjs/web / @solidjs/router server-function integration): fs-routes tree-shake, manifest.ts, directives, fns serialization/registration/shared and their specs. Fixes main landed in those files (#2249, #2238, #2243, #2245, #2241, #2261) live upstream now and are tracked for porting there. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
h3 v2 no longer waits sending the response until the first stream payload arrives, and ends up throwing away response status/header modifications.
What is the new behavior?
The h3 handler response is deferred again until the first
renderToStreampayload with response status/headers arrives. This is accomplished with theiterableh3 utility. h3 added back the functionality to wait for the first stream payload in h3js/h3#1512 as part of v2.0.1-rc.26.h3 v2.0.1-rc.26 also fixed some other oddities with headers, which in return broke our header workarounds - in particular the test
should preserve multiple Set-Cookie headers on redirect (RFC 6265). With all of the header fixes introduced in the past couple h3 releases, all our header workarounds seem to be not necessary anymore. Our tests now pass withoutproduceResponseWithEventHeaders(which included the workarounds).This PR also slightly overhauls the
should preserve multiple Set-Cookie headers on redirect (RFC 6265)test asserts, so that they result in more understandable error messages in case of a fail.Other information
Refs: #2229, h3js/h3#1510