feat: custom seroval plugins via serialization.plugins - #2250
Merged
Conversation
🦋 Changeset detectedLatest commit: a6eb444 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
brenelz
added a commit
that referenced
this pull request
Jul 29, 2026
Brings the v2 rc line (through 2.0.0-rc.6) into the Solid 2 branch. Ported main features onto the Solid 2 architecture: - Server-function error handler (#2262): wired through handleServerFunctionRequest's transformResult hook and the solid-start:server-fn-error-handler virtual module. - Custom seroval plugins (#2250): serialization.plugins now feeds the @solidjs/web codec on both the client transport and the server handler. - ~ alias fix for workspace packages (#2239): adopted appRootAlias in place of the global resolve.alias entry. - Dev toolbar (#2049, replaces the dev overlay): ported to Solid 2 (Errored/Loading, onSettled, two-arg createEffect, draft-mutation stores, terracotta 2 subpath imports, @solidjs/web Portal/Dynamic/JSX, createMemo(async) instead of createResource). Protocol-specific pieces (SerovalChunkReader, body-format markers) moved local to the toolbar. - Deferred stream response via h3 iterable() (#2231), StartHandler type (#2234), routerLoad restore (#2228), nonce on streaming redirect script (#2252), ResizeObserver-loop filter (#2240) all kept. Kept deleted (superseded by vite-plugin-solid / @solidjs/web / @solidjs/router server-function integration): fs-routes tree-shake, manifest.ts, directives, fns serialization/registration/shared and their specs. Fixes main landed in those files (#2249, #2238, #2243, #2245, #2241, #2261) live upstream now and are tracked for porting there. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Values seroval has no built-in support for (Mongo
ObjectId, PrismaDecimal,Temporal, custom classes) threwSerovalUnsupportedTypeErrorwhen crossing a server function boundary, with no way to register a plugin. Seroval has supportedcreatePluginsince v1; SolidStart just hardcoded its plugin list.The path resolves through a new
solid-start:seroval-pluginsvirtual module, wired likesolid-start:middleware. One module feeds bothfns/client.tsandfns/handler.ts, so client and server can't drift out of sync. Built-in plugins keep precedence (seroval takes the first passingtest(), user plugins are appended).Also adds a
@solidjs/start/serializationentrypoint re-exportingcreatePlugin,OpaqueReference, and plugin types. Without it users need their ownserovaldep, and a version mismatch wouldn't fail the build, it would emit plugin nodes the other end can't interpret.Two limits, both documented on the option:
solid-js/weband is unaffected.mode: "js"the payload is eval'd on the client, so a plugin'sserializemay reference globals only, not the plugin module's imports.deserialize(mode: "json", the default) has no such limit.Verified: 6 new unit tests, 1 new e2e round-tripping a custom class in both directions, and a manual browser check under both serialization modes. Full suites green (67 unit, 31 e2e, 31 bundled-dev).