fix(types): add StartHandler type that extends H3 - #2234
Merged
Conversation
…Script compatibility
🦋 Changeset detectedLatest commit: 2c99bcb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
brenelz
approved these changes
Jul 25, 2026
brenelz
added a commit
that referenced
this pull request
Jul 29, 2026
Brings the v2 rc line (through 2.0.0-rc.6) into the Solid 2 branch. Ported main features onto the Solid 2 architecture: - Server-function error handler (#2262): wired through handleServerFunctionRequest's transformResult hook and the solid-start:server-fn-error-handler virtual module. - Custom seroval plugins (#2250): serialization.plugins now feeds the @solidjs/web codec on both the client transport and the server handler. - ~ alias fix for workspace packages (#2239): adopted appRootAlias in place of the global resolve.alias entry. - Dev toolbar (#2049, replaces the dev overlay): ported to Solid 2 (Errored/Loading, onSettled, two-arg createEffect, draft-mutation stores, terracotta 2 subpath imports, @solidjs/web Portal/Dynamic/JSX, createMemo(async) instead of createResource). Protocol-specific pieces (SerovalChunkReader, body-format markers) moved local to the toolbar. - Deferred stream response via h3 iterable() (#2231), StartHandler type (#2234), routerLoad restore (#2228), nonce on streaming redirect script (#2252), ResizeObserver-loop filter (#2240) all kept. Kept deleted (superseded by vite-plugin-solid / @solidjs/web / @solidjs/router server-function integration): fs-routes tree-shake, manifest.ts, directives, fns serialization/registration/shared and their specs. Fixes main landed in those files (#2249, #2238, #2243, #2245, #2241, #2261) live upstream now and are tracked for porting there. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a types-only change. We have problems when using H3 types, which we do a few places as return types, and that happens in both hoisted and nested cases. If not familiar with hoisted/nested installs, see bottom of this PR.
createHandlerreturns h3'sH3, which isdeclare const H3: { new(): H3$1 }plustype H3 = H3$1. The classH3$1is exported only from h3's internaldist/h3.d.mts, never fromh3orh3/generic, so TypeScript cannot route the reference through the package and points at the internal file instead. When h3 also sits nested undernode_modules/@solidjs/start/node_modules, that path is not portable and emit fails.This PR
Implements so
createHandler(bothserverandserver/spa) returnsStartHandler, an interface declared by@solidjs/startthat extends h3'sH3, so it tracks h3 automatically and stays structurally interchangeable with it. Emit becomes:Tried to fix this in H3 itself (two middle rows), but only manage to resolve the hoisted cases, so it seems most feasible to solve this on the Start side of things to have it work in both cases.
.d.tsshapeclass H3exported from entryH3$1@solidjs/startHoisted/Nested
Hoisted means one copy of h3 at the top of the tree, reachable from the app:
Nested means solid-start has its own private copy: