feat: add a server function error handler - #2262
Merged
Merged
Conversation
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: a474969 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
adipascu
force-pushed
the
feat/server-fn-error-hook
branch
from
July 28, 2026 15:42
f25d012 to
acccfe0
Compare
lxsmnsyc
reviewed
Jul 28, 2026
adipascu
force-pushed
the
feat/server-fn-error-hook
branch
4 times, most recently
from
July 28, 2026 17:24
4f304fb to
2d14f17
Compare
adipascu
marked this pull request as ready for review
July 28, 2026 17:24
adipascu
force-pushed
the
feat/server-fn-error-hook
branch
from
July 28, 2026 17:29
2d14f17 to
ce68392
Compare
lxsmnsyc
reviewed
Jul 28, 2026
adipascu
marked this pull request as draft
July 28, 2026 18:00
adipascu
marked this pull request as ready for review
July 28, 2026 18:09
Contributor
Author
|
Thanks for the #1474 pointer, |
brenelz
added a commit
that referenced
this pull request
Jul 29, 2026
Brings the v2 rc line (through 2.0.0-rc.6) into the Solid 2 branch. Ported main features onto the Solid 2 architecture: - Server-function error handler (#2262): wired through handleServerFunctionRequest's transformResult hook and the solid-start:server-fn-error-handler virtual module. - Custom seroval plugins (#2250): serialization.plugins now feeds the @solidjs/web codec on both the client transport and the server handler. - ~ alias fix for workspace packages (#2239): adopted appRootAlias in place of the global resolve.alias entry. - Dev toolbar (#2049, replaces the dev overlay): ported to Solid 2 (Errored/Loading, onSettled, two-arg createEffect, draft-mutation stores, terracotta 2 subpath imports, @solidjs/web Portal/Dynamic/JSX, createMemo(async) instead of createResource). Protocol-specific pieces (SerovalChunkReader, body-format markers) moved local to the toolbar. - Deferred stream response via h3 iterable() (#2231), StartHandler type (#2234), routerLoad restore (#2228), nonce on streaming redirect script (#2252), ResizeObserver-loop filter (#2240) all kept. Kept deleted (superseded by vite-plugin-solid / @solidjs/web / @solidjs/router server-function integration): fs-routes tree-shake, manifest.ts, directives, fns serialization/registration/shared and their specs. Fixes main landed in those files (#2249, #2238, #2243, #2245, #2241, #2261) live upstream now and are tracked for porting there. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
handleServerFunctioncatches everything a server function throws and writes it straight into the response. Nothing else observes it, so the crash is invisible to monitoring, and whatever was thrown reaches the client as-is.What is the new behavior?
A new
serverFunctions.onErroroption names a module whose default export is called with the thrown value before it is serialized. Returning a value replaces what is sent, returningundefinedchanges nothing.Naming the module in the config rather than registering a handler at runtime keeps the app in sole control of it, so no dependency can reach the running server and take over reporting. It follows
serialization.pluginsfrom #1474, with its own virtual module because this one is bundled into the server only and may import a monitoring SDK.How other frameworks do this:
handleError, which observes and replaces: docs (src). Samehandler(...) ?? fallbackshape as this PR.onRequestError, observe only: docs (src)handleError, observe only: docs (src)errorhook, observe only: docs (src)functionMiddlewarewraps every server function, so an app catches aroundnext()itself: docs (src)Replacing matters for adapters whose runtime wraps failures, such as Effect's
FiberFailure. Unwrapping here keeps aResponsethrown through the wrapper recognised as control flow by thex instanceof Responsebranch.