Conversation
liumaker
force-pushed
the
fix/dom-render-error-detection
branch
from
September 8, 2026 07:24
6a5068b to
91d170c
Compare
This was referenced Sep 8, 2026
Open
Open
Open
Soul-Code
reviewed
Sep 8, 2026
Soul-Code
left a comment
Contributor
There was a problem hiding this comment.
提交组织问题:当前 #2 → #3 → #4 → #5 → #6 → #8 → #7 是一条累计提交链,但全部以 main 为 base,导致后一个 PR 包含前面全部修改,标题与实际审核范围不一致。请调整为独立 PR 或正确的 stacked PR;每个问题都应增加能够证明“main 失败、当前独立修改后通过”的最小回归测试。
已在 main 复现:合法红色公式会被 _has_katex_error() 误判;修改后正常红色公式通过,非法 KaTeX 仍能通过 DOM 状态识别。修复方向正确。
请增加两个回归测试:合法红色内容不得标记为错误;非法 KaTeX 必须返回 katex_error。补齐测试并拆清提交范围后可以接受。
This was referenced Sep 8, 2026
liumaker
force-pushed
the
fix/dom-render-error-detection
branch
from
September 10, 2026 08:20
91d170c to
467cb86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
旧逻辑会通过红色像素导致误判 KaTeX 错误。
修改前,合法红色公式可能被判为失败;修改后,只有 KaTeX/DOM 明确错误或截图链路异常才失败,并可返回具体错误文本。