Conversation
liumaker
force-pushed
the
fix/detailed-failure-result
branch
from
September 8, 2026 07:24
99fbae0 to
71e7fe1
Compare
Soul-Code
requested changes
Sep 8, 2026
Soul-Code
left a comment
Contributor
There was a problem hiding this comment.
提交组织问题：当前 #2 → #3 → #4 → #5 → #6 → #8 → #7 是一条累计提交链，但全部以 main 为 base，导致后一个 PR 包含前面全部修改，标题与实际审核范围不一致。请调整为独立 PR 或正确的 stacked PR；每个问题都应增加能够证明“main 失败、当前独立修改后通过”的最小回归测试。
compute_detailed() 解决了“真实零分与执行失败无法区分”的问题，方向正确。但当前所有 preprocess() 异常都固定记录为 FailureReport(stage="tokenize")。我模拟 process_for_katex() 抛出着色异常后，得到的仍是 stage=tokenize，这会让新增的详细错误报告产生错误诊断。
请分别标识结构校验、tokenize 和 colorize 阶段，并增加对应测试。
| gt_latex, gt_color_map = preprocess(gt) | ||
| pred_latex, pred_color_map = preprocess(pred) | ||
| except Exception as exc: | ||
| return CDMResult(None, None, None, None, "preprocess_failed", FailureReport("tokenize", type(exc).__name__, str(exc), summary)) |
Contributor
There was a problem hiding this comment.
这里把所有预处理异常都固定标成 tokenize。process_for_katex() 的着色异常也会被错误归类，导致详细结果无法定位真实阶段。请拆分结构校验、tokenize 与 colorize 的异常边界。
This was referenced Sep 8, 2026
Open
Open
Open
liumaker
force-pushed
the
fix/detailed-failure-result
branch
from
September 10, 2026 08:20
71e7fe1 to
3cf4273
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修改前无法区分真实零分和执行失败；修改后调用方直接读取
result.status，并可根据result.failure定位失败阶段。