Conversation
liumaker
force-pushed
the
fix/unbalanced-token-coloring
branch
from
September 8, 2026 07:24
4379569 to
edbeab9
Compare
Soul-Code
requested changes
Sep 8, 2026
Soul-Code
left a comment
Contributor
There was a problem hiding this comment.
提交组织问题:当前 #2 → #3 → #4 → #5 → #6 → #8 → #7 是一条累计提交链,但全部以 main 为 base,导致后一个 PR 包含前面全部修改,标题与实际审核范围不一致。请调整为独立 PR 或正确的 stacked PR;每个问题都应增加能够证明“main 失败、当前独立修改后通过”的最小回归测试。
main 已经包含“不平衡 token 或含换行 token 时跳过着色”的处理,因此本 PR 需要先说明新增行为解决了哪个尚未覆盖的真实失败。
当前 validate_formula_structure() 不具备正确的环境作用域判断:只要公式中出现任意 \begin{...},公式其他位置的 & 和 \ 都会被放过;转义判断也只检查前一个字符,没有按连续反斜杠的奇偶数判断。
建议暂不合并。请使用环境栈/作用域扫描重写校验,并提交能够证明 main 失败、修复后成功的真实输入和测试。
| if depth: | ||
| raise ValueError("Unmatched opening brace") | ||
|
|
||
| has_environment = bool(re.search(r"\\begin\{[^}]+\}", latex)) |
Contributor
There was a problem hiding this comment.
has_environment 只表示公式某处存在环境,不能证明当前 & 或 \\ 位于该环境内部。例如 x & \\begin{matrix}a\\end{matrix} 会通过这里。需要跟踪 begin/end 的真实作用域和嵌套关系。
This was referenced Sep 8, 2026
Open
Open
liumaker
force-pushed
the
fix/unbalanced-token-coloring
branch
from
September 10, 2026 08:20
edbeab9 to
a99458f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
未配对
{}、环境外&、环境外\\或包含换行控制的 token 如果继续包裹颜色,会进一步破坏语法,并可能把无效输入表现为普通 CDM 零分。