Conversation
liumaker
force-pushed
the
fix/render-retry-recovery
branch
from
September 8, 2026 07:24
d2abd78 to
6ef238c
Compare
Soul-Code
requested changes
Sep 8, 2026
Soul-Code
left a comment
Contributor
There was a problem hiding this comment.
提交组织问题：当前 #2 → #3 → #4 → #5 → #6 → #8 → #7 是一条累计提交链，但全部以 main 为 base，导致后一个 PR 包含前面全部修改，标题与实际审核范围不一致。请调整为独立 PR 或正确的 stacked PR；每个问题都应增加能够证明“main 失败、当前独立修改后通过”的最小回归测试。
我实际终止测试用 Chrome 后，当前实现能够重建渲染器并恢复到 F1=1.0，主要恢复流程有效。
但 Capture rectangle count mismatch 创建的 RenderResult 没有设置 error_type，_render_with_retries() 会把它当作不可重试错误，第一次失败后直接返回，与本 PR 的目标不一致。
请为该分支设置明确的可重试类型，并增加 WebDriver 断开、DOM/截图数量异常、确定性 KaTeX 错误和重试元数据的测试。
| rects = self.get_rects() | ||
| cropped_imgs = [] | ||
| if len(rects) != len(contents): | ||
| return [RenderResult(None, True, "Capture rectangle count mismatch", 0, 0) for _ in contents] |
Contributor
There was a problem hiding this comment.
这里没有设置 error_type，因此 _render_with_retries() 会把截图数量不一致当成不可重试错误并在第一次失败后返回。请标记为明确的可重试类型并补测试。
This was referenced Sep 8, 2026
Open
Open
Open
Open
liumaker
force-pushed
the
fix/render-retry-recovery
branch
from
September 10, 2026 08:21
6ef238c to
1fe50a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修改前重试行为与错误类型脱节；修改后确定性错误快速失败，临时错误最多恢复两次，并留下可供调用方诊断的尝试信息。