Conversation
liumaker
force-pushed
the
fix/safe-latex-colorization
branch
from
September 8, 2026 07:24
b76f8c4 to
846d797
Compare
This was referenced Sep 8, 2026
Open
Open
Open
Open
Soul-Code
requested changes
Sep 8, 2026
Soul-Code
left a comment
Contributor
There was a problem hiding this comment.
提交组织问题:当前 #2 → #3 → #4 → #5 → #6 → #8 → #7 是一条累计提交链,但全部以 main 为 base,导致后一个 PR 包含前面全部修改,标题与实际审核范围不一致。请调整为独立 PR 或正确的 stacked PR;每个问题都应增加能够证明“main 失败、当前独立修改后通过”的最小回归测试。
本 PR 能修复 #5 新增显式 \limits 后导致的 KaTeX 渲染失败,但目前修改范围明显大于已证明的问题。实测 \tag、\left...\right、\hspace 在修改前已经能够正常处理,目前没有测试证明这些额外分支是必要的。
建议缩小到有失败样本支持的结构命令,并为每个新增特殊分支提供修改前失败、修改后成功的回归测试;尤其需要说明它是在修 main 的问题,还是在修 #5 引入的回归。
liumaker
force-pushed
the
fix/safe-latex-colorization
branch
from
September 10, 2026 08:20
846d797 to
e0a4733
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改前着色可能改变语法或删除结构;修改后结构命令及参数保持原样,只有安全的数学内容参与颜色匹配。