[UPDATE]#1
Merged
Merged
Conversation
…s) (#4829) This PR fixes the issue pertaining to volume resize on VMWare for deploy as-is templates. VMware deploy as-is templates are those that are deployed as per the specification in the imported OVF. Hence override root disk size will not be adhered to for such templates. Moreover, when we deploy VMs in stopped state and resize the volume, the root disk doesn't get resized but the volume size is merely updated in the DB. This PR also includes the following (for deploy as-is templates): - Disables overriding root disk size during VM deployment on the UI - Disables selection of compute offerings with root disk size specified, at the time of deployment - Provided users with the option to deploy VM is stopped state via UI (so as to give an option to users to resize the volumes before starting the VM) Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
* initial chanes Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * changes Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * fix Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * make check explicit for instance name flag Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * allow hiding vm details (in ui) Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * condition based on name instead of displayname Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>
* autofocus into the first element (form/dialog) * add autofocus missing * add autofocus to missing elements
…role, to be in sync with the create role permission behavior (#4840) This PR removes the rule(s) validation with api names while importing a role. This will be in sync with the current create role permission behavior.
…e from 4846) (#4864) * Break loop if no exception on http request * Add new tests ensuring the correct execution flow of the RedfishClient retry * Log retry as "retry attempt %d/%d" * Fix string.format parameters order at RedfishClient.retryHttpRequest
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Fixes #4566 Sets `memoryintfreekbs` to zero if it is greater than `memorykbs`. Caused by KVM returning the RSS memory of the process running the VM rather than the free memory inside the VM. Co-authored-by: dahn <daan.hoogland@gmail.com>
This PR for fixes create zone form in mobile view
* [UPDATE] IRC on Readme. * Removed IRC references * let's fix bug reporting link as well
* Set isrecursive to false when fetching accounts * Adding exception handling
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
* api/server: fix hahost value in listHosts Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * fix Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * Update server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java Co-authored-by: dahn <daan.hoogland@gmail.com> * Update server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com> Co-authored-by: dahn <daan.hoogland@gmail.com>
Public IP addresses dedicated to one domain should not be accessed
by other domains. Also, root admin should be able to display all
public ip addresses in system.
Currently following issues exist
1. Public IP address assigned to one domain can be accessed by
other sibling domains
If use.system.public.ip is false then child domains should not
see public ip of ROOT domain
Before fix
```
(test1) mgt01 > list publicipaddresses listall=true fordisplay=true allocatedonly=false forvirtualnetwork=true filter=ipaddress,
{
"count": 59,
"publicipaddress": [
```
After fix
```
(test) mgt01 > list publicipaddresses listall=true fordisplay=true allocatedonly=false forvirtualnetwork=true filter=ipaddress,
{
"count": 10,
```
This contains 3 main changes (1) add NETWORK_STATS_ethX for all nics with public ips in VPC VRs (current: NETWORK_STATS_eth1) (2) DO NOT create records in user_statistics for each VPC tier (only one record per public nic per VPC VR) (3) send NetworkUsageCommand before unplugging a NIC with public IPs from VPC VR
logrotate in systemvms run every day. it exits with failure.
```
root@r-100-VM:~# systemctl status logrotate
● logrotate.service - Rotate log files
Loaded: loaded (/lib/systemd/system/logrotate.service; static; vendor preset: enabled)
Active: failed (Result: exit-code) since Thu 2021-03-23 00:00:01 UTC; 2 days ago
Docs: man:logrotate(8)
man:logrotate.conf(5)
Process: 25001 ExecStart=/usr/sbin/logrotate /etc/logrotate.conf (code=exited, status=1/FAILURE)
Main PID: 25001 (code=exited, status=1/FAILURE)
Warning: Journal has been rotated since unit was started. Log output is incomplete or unavailable.
```
it is because the logrotate for wtmp and btmp already exist in 4.15 systemvm template.
```
root@r-100-VM:~# cat /etc/logrotate.d/wtmp
/var/log/wtmp {
missingok
monthly
create 0664 root utmp
minsize 1M
rotate 1
}
root@r-100-VM:~# cat /etc/logrotate.d/btmp
/var/log/btmp {
missingok
monthly
create 0660 root utmp
rotate 1
}
```
remove them from /etc/logrotate.conf fixes the issue.
```
root@r-100-VM:~# systemctl status logrotate
● logrotate.service - Rotate log files
Loaded: loaded (/lib/systemd/system/logrotate.service; static; vendor preset: enabled)
Active: inactive (dead) since Thu 2021-03-25 00:00:01 UTC; 9h ago
Docs: man:logrotate(8)
man:logrotate.conf(5)
Process: 28211 ExecStart=/usr/sbin/logrotate /etc/logrotate.conf (code=exited, status=0/SUCCESS)
Main PID: 28211 (code=exited, status=0/SUCCESS)
Mar 25 00:00:01 r-100-VM systemd[1]: Starting Rotate log files...
Mar 25 00:00:01 r-100-VM systemd[1]: logrotate.service: Succeeded.
Mar 25 00:00:01 r-100-VM systemd[1]: Started Rotate log files.
```
config.json can have a property named 'docHelpMappings' which can be used to override docHelp suffixes.
In config.json admin can add mappings as follows:
"docHelpMappings": {
"virtual_machine.html": "some.html",
"some_string": "override_string"
}
UI will use these mappings and will make appropriate replacements in the documentation links for different sections and forms.
Addresses #4731
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
…#4869) We had critical issue with VR recently. The VRs of shared network or vpc stops working after some days. After investigation, I found that the disk space is full ``` root@r-10-VM:~# df Filesystem 1K-blocks Used Available Use% Mounted on /dev/vda5 2086316 2069932 0 100% / ``` logrotate/ryslog has compresses the log files, but space is not released. see `lsof |grep deleted` ``` root@r-10-VM:~# lsof |grep deleted rsyslogd 960 root 12w REG 254,5 493060096 137 /var/log/daemon.log.1 (deleted) rsyslogd 960 root 13w REG 254,5 17715200 110 /var/log/messages.1 (deleted) rsyslogd 960 root 16w REG 254,5 545968128 342 /var/log/auth.log.1 (deleted) rsyslogd 960 root 18w REG 254,5 38313984 341 /var/log/cron.log.1 (deleted) rsyslogd 960 962 in:imuxso root 12w REG 254,5 493060096 137 /var/log/daemon.log.1 (deleted) rsyslogd 960 962 in:imuxso root 13w REG 254,5 17715200 110 /var/log/messages.1 (deleted) rsyslogd 960 962 in:imuxso root 16w REG 254,5 545968128 342 /var/log/auth.log.1 (deleted) rsyslogd 960 962 in:imuxso root 18w REG 254,5 38313984 341 /var/log/cron.log.1 (deleted) rsyslogd 960 963 in:imklog root 12w REG 254,5 493060096 137 /var/log/daemon.log.1 (deleted) rsyslogd 960 963 in:imklog root 13w REG 254,5 17715200 110 /var/log/messages.1 (deleted) rsyslogd 960 963 in:imklog root 16w REG 254,5 545968128 342 /var/log/auth.log.1 (deleted) rsyslogd 960 963 in:imklog root 18w REG 254,5 38313984 341 /var/log/cron.log.1 (deleted) rsyslogd 960 964 in:imfile root 12w REG 254,5 493060096 137 /var/log/daemon.log.1 (deleted) rsyslogd 960 964 in:imfile root 13w REG 254,5 17715200 110 /var/log/messages.1 (deleted) rsyslogd 960 964 in:imfile root 16w REG 254,5 545968128 342 /var/log/auth.log.1 (deleted) rsyslogd 960 964 in:imfile root 18w REG 254,5 38313984 341 /var/log/cron.log.1 (deleted) rsyslogd 960 965 in:imudp root 12w REG 254,5 493060096 137 /var/log/daemon.log.1 (deleted) rsyslogd 960 965 in:imudp root 13w REG 254,5 17715200 110 /var/log/messages.1 (deleted) rsyslogd 960 965 in:imudp root 16w REG 254,5 545968128 342 /var/log/auth.log.1 (deleted) rsyslogd 960 965 in:imudp root 18w REG 254,5 38313984 341 /var/log/cron.log.1 (deleted) rsyslogd 960 966 rs:main root 12w REG 254,5 493060096 137 /var/log/daemon.log.1 (deleted) rsyslogd 960 966 rs:main root 13w REG 254,5 17715200 110 /var/log/messages.1 (deleted) rsyslogd 960 966 rs:main root 16w REG 254,5 545968128 342 /var/log/auth.log.1 (deleted) rsyslogd 960 966 rs:main root 18w REG 254,5 38313984 341 /var/log/cron.log.1 (deleted) ``` workaround: restarting rsyslog to release the space. ``` systemctl restart rsyslog ``` The root cause is, the following command does not work in 4.15 template ``` root@r-10-VM:~# invoke-rc.d rsyslog rotate [FAIL] Closing open files: rsyslogd failed! ``` Fix: use `/usr/lib/rsyslog/rsyslog-rotate` instead ``` root@r-10-VM:~# /usr/lib/rsyslog/rsyslog-rotate root@r-10-VM:~# cat /usr/lib/rsyslog/rsyslog-rotate if [ -d /run/systemd/system ]; then systemctl kill -s HUP rsyslog.service else invoke-rc.d rsyslog rotate > /dev/null fi ```
* zone wizard: restored the basic networking * set enabled Basic Networking
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Thanks @rubieHess to point it out. see #4800 (comment)
If the VPC has redundant VR's but doesnt have any tiers or there are no running VM's in a VPC then disable the gateway check for VR
If a vm belongs to shared network then display the list of ip addresses available which can be used to assign for secondary IP addresses. Also display "Public IP addresses" tab for shared networks
If VM details contain rootdisksize, volume entry in DB should reflect correct size when VM reset is performed. Fixes #3957 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> Conflicts: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
* Fix VMware OVF properties copy from template * Fix vapp marvin test * Remove unused code * Fix check for deploy as is details * Access class fields
Fixes #4908 Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
Co-authored-by: Daniel Augusto Veronezi Salvador <daniel@scclouds.com.br>
Co-authored-by: Daniel Augusto Veronezi Salvador <daniel@scclouds.com.br>
#4916) This PR includes fixes to complete the Korean language support of the new CloudStack UI. CloudStack explains that it supports Korean, but only some features are translated. Compared to the en-us.json file, it is not up to date on new features. To support Korean language support for new features and more modern Korean language support, the contents of en-us.json were copied to the ko-kr.json file and retranslated into Korean. Co-authored-by: Dajeong-Park <ekwjd7182@gmail.com>
* fixes the color style of the filter icon * fixes for router leave/enter
…isks which are there before destroy in case of VMware (#4493) This PR fixes: #4462 Problem Statement: In case of VMware, when a VM having multiple data disk is destroyed (without expunge) and tried to recover the VM then the previous data disks are not attached to the VM like before destroy. Only root disk is attached to the VM. Root cause: All data disks were removed as part of VM destroy. Only the volumes which are selected to delete (while destroying VM) are supposed to be detached and destroyed. Solution: During VM destroy, detach and destroy only volumes which are selected during VM destroy. Detach the other volumes during expunge of VM.
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Fixes the issue of not being able to select the diskofferingid while creating volumes from snapshots of ROOT volumes
added support to update tags of disk and network offerings from UI fix deletion of the last tag
* debian: remove duplicate agent jar copy The cloud-agent is dependency of the KVM hypervisor plugin, don't explicitly install/copy it again. Fixes #4906 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> * Update rules
This PR proposes adding Exception UnavailableCommandException at the ExceptionErrorCodeMap
This PR sets cloudian.connector.enabled as not dynamic since cloudian requires the cloudianSsoLogin API which is added only once the MS is restarted
For an auto-generated form, with list mapping of action, mapped API parameter was not getting added to the request when first index from the list is selected. Change added to fix this. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Co-authored-by: Daniel Augusto Veronezi Salvador <daniel@scclouds.com.br>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?